feat(plugin-api): add build time to environment compile hook #6584
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull Request Overview
This PR adds a time parameter to the onAfterEnvironmentCompile hook to track individual environment build duration in milliseconds. The implementation includes type definitions, hook parameter updates, documentation in both English and Chinese, and test coverage.
Key Changes
- Added
time: numberparameter toOnAfterEnvironmentCompileFntype definition with JSDoc documentation - Updated
registerBuildHookandregisterDevHookto extract and passtimeto the hook - Added test assertion to verify
timeis greater than 0
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/types/hooks.ts | Added time parameter to OnAfterEnvironmentCompileFn type with documentation |
| packages/core/src/hooks.ts | Implemented time extraction and passing to onAfterEnvironmentCompile hook in both build and dev modes |
| website/docs/en/shared/onAfterEnvironmentCompile.mdx | Added English documentation for the new time parameter |
| website/docs/zh/shared/onAfterEnvironmentCompile.mdx | Added Chinese documentation for the new time parameter |
| e2e/cases/plugin-api/plugin-hooks-environment/index.test.ts | Added test to verify time parameter is provided and greater than 0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Adds new
timeparameter toonAfterEnvironmentCompilehook for tracking environment build duration.Checklist